Fix is_closed state and position for DynamicPergola covers in Overkiz by iMicknl · Pull Request #170983 · home-assistant/core

iMicknl · 2026-05-17T14:07:32Z

Proposed change

The DynamicPergola widget uses core:OpenClosedState and core:ClosureState, unlike bioclimatic pergolas that use core:SlatsOpenClosedState. Without a widget-level override, the UIClass.PERGOLA fallback looked for slats state that doesn't exist on this device, causing the cover to report unknown state.

Fixes #170812

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes is_closed state is unknown for DynamicPergola covers in Overkiz #170812
This PR is related to issue:
Link to documentation pull request:
Link to developer documentation pull request:
Link to frontend pull request:

Checklist

I understand the code I am submitting and can explain how it works.
The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.
Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

The DynamicPergola widget uses core:OpenClosedState and core:ClosureState, unlike bioclimatic pergolas that use core:SlatsOpenClosedState. Without a widget-level override, the UIClass.PERGOLA fallback looked for slats state that doesn't exist on this device, causing the cover to report unknown state. Fixes home-assistant#170812

The slats-based behavior (core:SlatsOpenClosedState, tilt orientation) is specific to BioclimaticPergola devices. Make the UIClass.PERGOLA default use the simpler core:OpenClosedState and core:ClosureState which works for DynamicPergola and other standard pergola widgets.

Ensures the deployment-based pergola awning widget has snapshot coverage to prevent regressions when changing the UIClass.PERGOLA default.

Copilot

Pull request overview

This PR fixes Overkiz pergola cover state/position handling by updating the Pergola UIClass defaults to use core:OpenClosedState + core:ClosureState, while adding a widget-specific override to preserve the existing bioclimatic pergola (slats/tilt) behavior.

Changes:

Update UIClass.PERGOLA mapping to use core:OpenClosedState for is_closed and core:ClosureState for position.
Add a UIWidget.BIOCLIMATIC_PERGOLA override to keep slats open/closed + orientation (tilt-only) support.
Extend Overkiz test fixtures and service/snapshot coverage for DynamicPergola and PergolaHorizontalAwning.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
`homeassistant/components/overkiz/cover.py`	Adjusts pergola description defaults and adds a bioclimatic-pergola widget override to avoid “unknown” cover state.
`tests/components/overkiz/test_cover.py`	Adds new fixture devices and service-action assertions for dynamic pergola + pergola horizontal awning.
`tests/components/overkiz/fixtures/setup/cloud_somfy_tahoma_v2_europe.json`	Adds device definitions/states for the new pergola devices used by tests.
`tests/components/overkiz/snapshots/test_cover.ambr`	Updates snapshots to reflect the new devices and revised pergola state/position behavior.

DYNAMIC_PERGOLA and PERGOLA_HORIZONTAL_AWNING use the same fixture file as SHUTTER, so adding them to SNAPSHOT_FIXTURES caused redundant snapshot runs with unstable json0/json1/json2 IDs.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

The PergolaHorizontalAwning and PergolaHorizontalAwningUno widget descriptions were missing stop_command, causing the stop button to not appear in the UI despite the device supporting the stop command. Fixes home-assistant#171014

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

…pergola-state

…home-assistant#170983)

…#170983)

…2026.5.2 ➔ 2026.5.3) (#568) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/home-operations/home-assistant](https://ghcr.io/home-operations/home-assistant) ([source](https://github.com/home-assistant/core)) | patch | `2026.5.2` → `2026.5.3` | --- ### Release Notes <details> <summary>home-assistant/core (ghcr.io/home-operations/home-assistant)</summary> ### [`v2026.5.3`](https://github.com/home-assistant/core/releases/tag/2026.5.3) [Compare Source](home-assistant/core@2026.5.2...2026.5.3) - Bump qbittorrent-api to 2026.5.1 ([@lumatijev] - [#170181]) ([qbittorrent docs]) (dependency) - Improve iaqualink 429 handling ([@flz] - [#170231]) ([iaqualink docs]) - Fix Apple TV keyboard focus binary\_sensor missing on cold start ([@kroehre] - [#170360]) ([apple\_tv docs][apple_tv docs]) - Add tilt controls for UpDownSheerScreen in Overkiz ([@dankarization] - [#170563]) ([overkiz docs]) - Fix ValueError when turning on blebox light with brightness set to 0 ([@bkobus-bbx] - [#170769]) ([blebox docs]) - Bump aiodns to 4.0.3 ([@bdraco] - [#170865]) ([dnsip docs]) (dependency) - Populate uid and recurrence\_id in CalDAV calendar events ([@frenck] - [#170910]) ([caldav docs]) - Fix is\_closed state for SlidingDiscreteGateWithPedestrianPosition covers in Overkiz ([@iMicknl] - [#170913]) ([overkiz docs]) - Disable USB discovery for teleinfo ([@puddly] - [#170933]) ([teleinfo docs]) - Fix utility meter next\_reset shifting forward on entity rename ([@frenck] - [#170957]) ([utility\_meter docs][utility_meter docs]) - Use correct state\_class for utility meters with device classes that don't support total\_increasing ([@frenck] - [#170962]) ([utility\_meter docs][utility_meter docs]) - Reduce GoodWe connect retries to avoid blocking startup ([@frenck] - [#170964]) ([goodwe docs]) - Fix is\_closed state for DiscretePositionableGarageDoor in Overkiz ([@iMicknl] - [#170981]) ([overkiz docs]) - Fix controls for OpenCloseGate4T (rts:GateOpenerRTS4TComponent) in Overkiz ([@iMicknl] - [#170987]) ([overkiz docs]) - Prevent Google Assistant entity sync from blocking startup ([@frenck] - [#170991]) ([google\_assistant docs][google_assistant docs]) - Load template extensions by class to prevent import deadlock ([@frenck] - [#170995]) - Use asyncio.get\_running\_loop() in emulated\_hue UPnP responder ([@frenck] - [#171000]) ([emulated\_hue docs][emulated_hue docs]) - Fix Netatmo valve KeyError when hvac\_action state is unavailable in Overkiz ([@frenck] - [#171004]) ([overkiz docs]) - Fix time trigger crash when using entity\_id dict format without offset ([@frenck] - [#171006]) ([homeassistant docs]) - Fix threshold preview crash when hysteresis is not provided ([@frenck] - [#171009]) ([threshold docs]) - Fix Growatt mix device IndexError when chart data is empty ([@frenck] - [#171012]) ([growatt\_server docs][growatt_server docs]) - Fix SleepIQ timer units: seconds should be minutes for core climate and foot warmer ([@frenck] - [#171013]) ([sleepiq docs]) - Fix Control4 climate crash when humidity is 'Undefined' ([@frenck] - [#171015]) ([control4 docs]) - Fix manual alarm panel crash on restore with invalid state ([@frenck] - [#171016]) ([manual docs]) - Handle Daikin connection errors gracefully in coordinator ([@frenck] - [#171017]) ([daikin docs]) - Fix shorthand template conditions in choose blocks crashing all automations ([@frenck] - [#171018]) - Add additional overrides to cover entity in Overkiz ([@iMicknl] - [#171019]) ([overkiz docs]) - Fix Verisure alarm crash when cloud rejects arm/disarm command ([@frenck] - [#171024]) ([verisure docs]) - Add stop command to Overkiz pergola horizontal awning covers ([@frenck] - [#171034]) ([overkiz docs]) - Fix WeatherFlow websocket crash when data payload is None ([@frenck] - [#171037]) ([weatherflow\_cloud docs][weatherflow_cloud docs]) - Bump pyIntesishome to 1.8.8 ([@jnimmo] - [#171041]) ([intesishome docs]) (dependency) - Return media\_content\_id as string in forked\_daapd ([@frenck] - [#171059]) ([forked\_daapd docs][forked_daapd docs]) - Bump aioimmich to 0.14.1 ([@mib1185] - [#171138]) ([immich docs]) (dependency) - Fix controls for UpDownGarageDoor4T and additional 4T covers in Overkiz ([@iMicknl] - [#171144]) ([overkiz docs]) - Fix ZHA config entries using a URI without a port ([@puddly] - [#171164]) ([zha docs]) - Fix is\_closed state and position for DynamicPergola covers in Overkiz ([@iMicknl] - [#170983]) ([overkiz docs]) - Fix tilt and position support for VenetianBlind covers in Overkiz ([@iMicknl] - [#170974]) ([overkiz docs]) - Fix blebox light temperature scaling ([@bkobus-bbx] - [#170573]) ([blebox docs]) [#169484]: home-assistant/core#169484 [#170146]: home-assistant/core#170146 [#170181]: home-assistant/core#170181 [#170231]: home-assistant/core#170231 [#170360]: home-assistant/core#170360 [#170563]: home-assistant/core#170563 [#170573]: home-assistant/core#170573 [#170769]: home-assistant/core#170769 [#170840]: home-assistant/core#170840 [#170865]: home-assistant/core#170865 [#170910]: home-assistant/core#170910 [#170913]: home-assistant/core#170913 [#170933]: home-assistant/core#170933 [#170957]: home-assistant/core#170957 [#170962]: home-assistant/core#170962 [#170964]: home-assistant/core#170964 [#170974]: home-assistant/core#170974 [#170981]: home-assistant/core#170981 [#170983]: home-assistant/core#170983 [#170987]: home-assistant/core#170987 [#170991]: home-assistant/core#170991 [#170995]: home-assistant/core#170995 [#171000]: home-assistant/core#171000 [#171004]: home-assistant/core#171004 [#171006]: home-assistant/core#171006 [#171009]: home-assistant/core#171009 [#171012]: home-assistant/core#171012 [#171013]: home-assistant/core#171013 [#171015]: home-assistant/core#171015 [#171016]: home-assistant/core#171016 [#171017]: home-assistant/core#171017 [#171018]: home-assistant/core#171018 [#171019]: home-assistant/core#171019 [#171024]: home-assistant/core#171024 [#171034]: home-assistant/core#171034 [#171037]: home-assistant/core#171037 [#171041]: home-assistant/core#171041 [#171059]: home-assistant/core#171059 [#171138]: home-assistant/core#171138 [#171144]: home-assistant/core#171144 [#171164]: home-assistant/core#171164 [@bdraco]: https://github.com/bdraco [@bkobus-bbx]: https://github.com/bkobus-bbx [@dankarization]: https://github.com/dankarization [@flz]: https://github.com/flz [@frenck]: https://github.com/frenck [@iMicknl]: https://github.com/iMicknl [@jnimmo]: https://github.com/jnimmo [@kroehre]: https://github.com/kroehre [@lumatijev]: https://github.com/lumatijev [@mib1185]: https://github.com/mib1185 [@puddly]: https://github.com/puddly [apple_tv docs]: https://www.home-assistant.io/integrations/apple_tv/ [blebox docs]: https://www.home-assistant.io/integrations/blebox/ [caldav docs]: https://www.home-assistant.io/integrations/caldav/ [control4 docs]: https://www.home-assistant.io/integrations/control4/ [daikin docs]: https://www.home-assistant.io/integrations/daikin/ [dnsip docs]: https://www.home-assistant.io/integrations/dnsip/ [emulated_hue docs]: https://www.home-assistant.io/integrations/emulated_hue/ [forked_daapd docs]: https://www.home-assistant.io/integrations/forked_daapd/ [goodwe docs]: https://www.home-assistant.io/integrations/goodwe/ [google_assistant docs]: https://www.home-assistant.io/integrations/google_assistant/ [growatt_server docs]: https://www.home-assistant.io/integrations/growatt_server/ [homeassistant docs]: https://www.home-assistant.io/integrations/homeassistant/ [iaqualink docs]: https://www.home-assistant.io/integrations/iaqualink/ [immich docs]: https://www.home-assistant.io/integrations/immich/ [intesishome docs]: https://www.home-assistant.io/integrations/intesishome/ [manual docs]: https://www.home-assistant.io/integrations/manual/ [overkiz docs]: https://www.home-assistant.io/integrations/overkiz/ [qbittorrent docs]: https://www.home-assistant.io/integrations/qbittorrent/ [sleepiq docs]: https://www.home-assistant.io/integrations/sleepiq/ [teleinfo docs]: https://www.home-assistant.io/integrations/teleinfo/ [threshold docs]: https://www.home-assistant.io/integrations/threshold/ [utility_meter docs]: https://www.home-assistant.io/integrations/utility_meter/ [verisure docs]: https://www.home-assistant.io/integrations/verisure/ [weatherflow_cloud docs]: https://www.home-assistant.io/integrations/weatherflow_cloud/ [zha docs]: https://www.home-assistant.io/integrations/zha/ </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/568

iMicknl added 4 commits May 17, 2026 13:35

Add PergolaHorizontalAwning test fixture for Overkiz cover

fec60d9

Ensures the deployment-based pergola awning widget has snapshot coverage to prevent regressions when changing the UIClass.PERGOLA default.

Add PergolaHorizontalAwning test fixture for Overkiz cover

117f2f8

Ensures the deployment-based pergola awning widget has snapshot coverage to prevent regressions when changing the UIClass.PERGOLA default.

iMicknl added this to the 2026.5.3 milestone May 17, 2026

Copilot AI review requested due to automatic review settings May 17, 2026 14:07

home-assistant Bot added bugfix cla-signed has-tests integration: overkiz small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage by-code-owner Quality Scale: No score labels May 17, 2026

Copilot started reviewing on behalf of iMicknl May 17, 2026 14:07 View session

Copilot AI reviewed May 17, 2026

View reviewed changes

Comment thread tests/components/overkiz/test_cover.py

Remove duplicate snapshot fixtures for cloud_somfy_tahoma_v2_europe

ec00ab7

DYNAMIC_PERGOLA and PERGOLA_HORIZONTAL_AWNING use the same fixture file as SHUTTER, so adding them to SNAPSHOT_FIXTURES caused redundant snapshot runs with unstable json0/json1/json2 IDs.

iMicknl marked this pull request as ready for review May 17, 2026 14:42

Copilot AI review requested due to automatic review settings May 17, 2026 14:42

Copilot started reviewing on behalf of iMicknl May 17, 2026 14:42 View session

Copilot AI reviewed May 17, 2026

View reviewed changes

iMicknl linked an issue May 17, 2026 that may be closed by this pull request

Stop button missing for PergolaHorizontalAwning covers in Overkiz #171014

Closed

iMicknl mentioned this pull request May 17, 2026

Add stop command to Overkiz pergola horizontal awning covers #171034

Merged

21 tasks

Merge branch 'dev' into overkiz/fix-dynamic-pergola-state

c80c2a6

Copilot AI review requested due to automatic review settings May 18, 2026 10:16

Copilot started reviewing on behalf of iMicknl May 18, 2026 10:16 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/dev' into overkiz/fix-dynamic-…

9e6186c

…pergola-state

zweckj approved these changes May 18, 2026

View reviewed changes

zweckj merged commit 4582c56 into home-assistant:dev May 18, 2026
33 checks passed

jnimmo pushed a commit to jnimmo/core that referenced this pull request May 18, 2026

Fix is_closed state and position for DynamicPergola covers in Overkiz (…

db89cb9

…home-assistant#170983)

frenck modified the milestone: 2026.5.3 May 19, 2026

frenck added the cherry-picked label May 19, 2026

frenck pushed a commit that referenced this pull request May 19, 2026

Fix is_closed state and position for DynamicPergola covers in Overkiz (…

1e90882

…#170983)

frenck mentioned this pull request May 19, 2026

2026.5.3 #171185

Merged

github-actions Bot locked and limited conversation to collaborators May 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix is_closed state and position for DynamicPergola covers in Overkiz#170983

Fix is_closed state and position for DynamicPergola covers in Overkiz#170983
zweckj merged 8 commits into
home-assistant:devfrom
iMicknl:overkiz/fix-dynamic-pergola-state

iMicknl commented May 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

iMicknl commented May 17, 2026

Proposed change

Type of change

Additional information

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants